Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

Changed Docker image to alpine:3.6 #18

Merged
merged 1 commit into from
Jun 2, 2017
Merged

Changed Docker image to alpine:3.6 #18

merged 1 commit into from
Jun 2, 2017

Conversation

@juanjux
Copy link
Contributor

@juanjux juanjux commented Jun 1, 2017

  • The images use 33MB less.
  • Performance is similar.
  • Comes with Python 3.6 by default so we don't have to use an alpine variant anymore.

smola
smola suggested changes Jun 2, 2017
View reviewed changes
native/python_package/test/test_alpine.sh Outdated
# Alpine 3.6:
time sh -c './sendmsg.py /usr/lib/python2.7/*.py | docker run -i --name python_driver --rm 1edcc008c3f6 /opt/driver/bin/native > /dev/null'
# python-alpine (3.5)
#time sh -c './sendmsg.py /usr/lib/python2.7/*.py | docker run -i --name python_driver --rm 04d2a815082e /opt/driver/bin/native > /dev/null'
Copy link
Member

@smola smola Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not leave dead code in comments, this just accumulates over time and you have the code in the git history.

Copy link
Contributor Author

@juanjux juanjux Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smola done

@juanjux
Changed Docker image to alpine:3.6
8b8b8aa 
- The images use 33MB less.
- Performance is similar.
- Comes with Python 3.6 by default so we don't have to use an alpine variant anymore.
- Fixed outdated test
- Removed old code

Removed old benchmark code
@smola smola merged commit 65a7694 into bblfsh:master Jun 2, 2017
@juanjux juanjux deleted the feature/alpine36 branch June 22, 2017 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@smola smola smola approved these changes

@abeaumont abeaumont abeaumont approved these changes

@alcortesm alcortesm alcortesm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juanjux @smola @abeaumont @alcortesm