This repository was archived by the owner on Mar 8, 2020. It is now read-only.
parser: Prevent duplicate tokens from happening and related tasks #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driver/normalizer/parser.go
Outdated
| "FunctionDef": {"body": true, "decorator_list": true}, | ||
| "Lambda": {"body": true}, | ||
| "arguments": {"defaults": true}, | ||
| "Try": {"body": true, "orelse": true, "finalbody": true, "handlers": true}, |
There was a problem hiding this comment.
LGTM!
I am not very familiarized with the API to annotate nodes, out of curiosity, how is removing handlers: true affecting?
Contributor
Author
There was a problem hiding this comment.
It means that Try.handlers are not promoted to node. https://github.com/bblfsh/python-driver/pull/80/files#diff-56de3fb994af9b7ff9f631ea2d5aec42 shows how the uast changes in this case.
manucorporat
approved these changes
Aug 22, 2017
* Annotates new node type * Update the testsuite
Contributor
Author
|
Rebased for conflict resolution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on bblfsh/sdk#164
Fixes #75