Fix issue #58. Fix more unbound-column errors #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
juanjux
commented
Aug 9, 2017
juanjux
commented
- Fixes python-driver/issues/58
- Fixes more "column out of bounds" errors but there are still two instances of this left on the integration tests in these cases:
- Empty files: because of a just discovered bug in the SDK with empty files: The SDK changes 0-columns and lines for 1 but checks empty files against 0 size sdk#160
- Code inside f-strings: we fix the position of several of these nodes but some can't be easily fixed with the tokenizer approach (like the one that fails in the test).
juanjux
force-pushed
the
fix/nondict_noneliteral
branch
from
719f922 to
5591a18
Compare
abeaumont
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.