fix(RemoveToolkitArgFromImageToolkitOperationConstructorRector): skip closures in $toolkit count

The 'exactly once' usage count for $toolkit descended into nested
closures and arrow-functions, where a `$toolkit` parameter shadow or
`use ($toolkit)` capture would have inflated the count and caused the
rector to refuse to rewrite an otherwise-valid constructor.

Contrib search (api.tresbien.tech) found zero ImageToolkitOperationBase
subclasses with this pattern, so the impact is purely defensive — but
the tightening is cheap and locks in the intended outer-scope-only
semantic. No fixture added (no realistic trigger).

Author: bbrala

src/Drupal11/Rector/Deprecation/RemoveToolkitArgFromImageToolkitOperationConstructorRector.php

@@ -6,9 +6,12 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Arg;
+use PhpParser\Node\Expr\ArrowFunction;
+use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt\Class_;
+use PhpParser\NodeVisitor;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -109,9 +112,15 @@ public function refactor(Node $node): ?Node
         }
 
         // Count all usages of the $toolkit variable inside the constructor body
-        // to ensure it is only passed to parent::__construct().
+        // to ensure it is only passed to parent::__construct(). Skip the
+        // bodies of nested closures and arrow-functions — a `$toolkit`
+        // parameter or `use ($toolkit)` capture there shadows the outer
+        // variable and must not affect the outer-scope count.
         $toolkitUsageCount = 0;
-        $this->traverseNodesWithCallable($constructor->stmts ?? [], function (Node $innerNode) use ($toolkitVarName, &$toolkitUsageCount): ?Node {
+        $this->traverseNodesWithCallable($constructor->stmts ?? [], function (Node $innerNode) use ($toolkitVarName, &$toolkitUsageCount): null|int {
+            if ($innerNode instanceof Closure || $innerNode instanceof ArrowFunction) {
+                return NodeVisitor::DONT_TRAVERSE_CHILDREN;
+            }
             if ($innerNode instanceof Variable && $this->isName($innerNode, $toolkitVarName)) {
                 ++$toolkitUsageCount;
             }