fix: few issues #124
Merged
fix: few issues #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the ECS task invocation and strengthens the resume script by pre-checking resource existence.
- Fixes a mismatch in the Flyway task definition name used by
aws ecs run-task - Adds checks in the resume script to skip non-existent ECS clusters/services
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infrastructure/api/ecs.tf | Updated --task-definition argument to remove -task suffix |
| .github/scripts/resume.sh | Added AWS CLI checks for cluster and service existence |
Comments suppressed due to low confidence (1)
infrastructure/api/ecs.tf:111
- The task definition name
${var.app_name}-flywayno longer matches the resource family (which is defined with a-flyway-tasksuffix). Please ensure this value exactly matches the registered task definition name.
--task-definition ${var.app_name}-flyway \
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.