Skip to content

Conversation

@mishraomp
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 28, 2025 21:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Terraform configuration for multiple modules to remove the legacy DynamoDB locking mechanism and enable native S3 locking. Key changes include:

  • Removal of the statelock_table_name variable from locals in all modules.
  • Replacement of the dynamodb_table configuration with use_lockfile set to true.
  • Addition of the repo_name variable in the API module.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
terraform/frontend/terragrunt.hcl Removed statelock_table_name and replaced dynamodb_table with use_lockfile configuration.
terraform/database/terragrunt.hcl Removed statelock_table_name and replaced dynamodb_table with use_lockfile configuration.
terraform/api/terragrunt.hcl Removed statelock_table_name, replaced dynamodb_table with use_lockfile, and added repo_name.
Comments suppressed due to low confidence (3)

terraform/frontend/terragrunt.hcl:29

  • Consider expanding the inline comment to reference the migration from DynamoDB table locking to native S3 locking, which can be helpful for future maintenance.
    use_lockfile   = true  # Enable native S3 locking

terraform/database/terragrunt.hcl:30

  • Consider updating the inline comment with additional context about using native S3 locking over the previous DynamoDB-based approach for clarity in configuration changes.
    use_lockfile   = true  # Enable native S3 locking

terraform/api/terragrunt.hcl:21

  • Consider adding an inline comment that explains the purpose and usage of the newly added 'repo_name' variable to enhance clarity for future maintainers.
  repo_name               = get_env("repo_name")

@mishraomp mishraomp merged commit e99b0f0 into main Jun 28, 2025
18 of 19 checks passed
@mishraomp mishraomp deleted the fix/terragrunt branch June 28, 2025 21:35
@mishraomp mishraomp self-assigned this Jun 28, 2025
@mishraomp mishraomp added the chore regular house keeping, and improvements label Jun 28, 2025
@mishraomp mishraomp moved this from New to Done in NRIDS - Architecture Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore regular house keeping, and improvements

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants