Skip to content

Conversation

@DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Apr 24, 2025


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts self-assigned this Apr 24, 2025
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Apr 24, 2025
@DerekRoberts DerekRoberts marked this pull request as ready for review April 24, 2025 20:34
Copilot AI review requested due to automatic review settings April 24, 2025 20:34
@DerekRoberts DerekRoberts marked this pull request as draft April 24, 2025 20:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to test the crunchy deployer action by modifying CI workflow configuration.

  • Commented out trigger settings in the pr-open workflow to potentially disable automatic triggers.
  • Updated the deployer-db job to reference a remote workflow from the quickstart-openshift-helpers repository.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr-open.yml Commented out triggers to adjust CI trigger configuration.
.github/workflows/.deployer.yml Updated the job to use a remote workflow reference for deployment.

@github-project-automation github-project-automation bot moved this from Active to Done in DevOps (NR) Apr 27, 2025
@DerekRoberts DerekRoberts reopened this Apr 27, 2025
@github-project-automation github-project-automation bot moved this from Done to Parked in DevOps (NR) Apr 27, 2025
@DerekRoberts DerekRoberts moved this from Parked to Active in DevOps (NR) Apr 28, 2025
@DerekRoberts DerekRoberts force-pushed the chore/crunchyAction branch 2 times, most recently from 5ca3eb7 to 61bebb2 Compare May 1, 2025 17:42
@github-project-automation github-project-automation bot moved this from Done to Parked in DevOps (NR) May 9, 2025
@github-project-automation github-project-automation bot moved this from Parked to Done in DevOps (NR) May 9, 2025
@DerekRoberts DerekRoberts reopened this May 9, 2025
@github-project-automation github-project-automation bot moved this from Done to Parked in DevOps (NR) May 9, 2025
DerekRoberts and others added 4 commits May 8, 2025 22:20
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
@mishraomp
Copy link
Collaborator

@DerekRoberts it is in a good shape now, I think we can run the crunchy action in parallel while images are getting build, it will speed up the pipeline.

@github-project-automation github-project-automation bot moved this from Parked to Done in DevOps (NR) May 9, 2025
@DerekRoberts DerekRoberts reopened this May 9, 2025
@github-project-automation github-project-automation bot moved this from Done to Parked in DevOps (NR) May 9, 2025
@DerekRoberts DerekRoberts changed the title chore(ci): test crunchy deployer action chore(ci): crunchy deployer action May 9, 2025
@DerekRoberts DerekRoberts requested review from Copilot and mishraomp May 9, 2025 19:25
@DerekRoberts DerekRoberts moved this from Parked to Active in DevOps (NR) May 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the deployment configuration for the Crunchy PostgreSQL cluster and streamlines related workflows. Key changes include:

  • Updating chart values for PostgreSQL and storage settings in charts/crunchy/values.yml.
  • Enhancing secret retrieval logic in charts/app/templates/secret.yaml.
  • Replacing custom removal commands with the bcgov/action-crunchy action in the pr-close workflow and updating deployment steps in .github/workflows/.deployer.yml.

Reviewed Changes

Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.

File Description
charts/crunchy/values.yml Updated PostgreSQL version and adjusted storage size and postGISVersion formatting.
charts/app/templates/secret.yaml Modified secret naming logic and added explicit lookup validations.
.github/workflows/pr-close.yml Replaced manual DB user removal steps with the new bcgov/action-crunchy action.
.github/workflows/.deployer.yml Updated deployment steps to use the new crunchy action and added a debugging step.
Files not reviewed (7)
  • .github/workflows/.deployer-db.yml: Language not supported
  • backend/package.json: Language not supported
  • charts/crunchy/Chart.yaml: Language not supported
  • charts/crunchy/templates/PostgresCluster.yaml: Language not supported
  • charts/crunchy/templates/_helpers.tpl: Language not supported
  • charts/crunchy/templates/knp.yaml: Language not supported
  • charts/crunchy/templates/secret.yaml: Language not supported
Comments suppressed due to low confidence (1)

charts/crunchy/values.yml:8

  • The postGISVersion value was changed from a quoted string to an unquoted numerical value. Please confirm that this type change is intentional and compatible with downstream processing.
postGISVersion: 3.4

@github-project-automation github-project-automation bot moved this from Active to Waiting in DevOps (NR) May 9, 2025
@mishraomp mishraomp merged commit 54d0ab0 into main May 10, 2025
26 of 27 checks passed
@github-project-automation github-project-automation bot moved this from Waiting to Done in DevOps (NR) May 10, 2025
@mishraomp mishraomp deleted the chore/crunchyAction branch May 10, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants