-
Notifications
You must be signed in to change notification settings - Fork 7
chore(ci): crunchy deployer action #2341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to test the crunchy deployer action by modifying CI workflow configuration.
- Commented out trigger settings in the pr-open workflow to potentially disable automatic triggers.
- Updated the deployer-db job to reference a remote workflow from the quickstart-openshift-helpers repository.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/pr-open.yml | Commented out triggers to adjust CI trigger configuration. |
| .github/workflows/.deployer.yml | Updated the job to use a remote workflow reference for deployment. |
e2b37fa to
268d590
Compare
103a541 to
b1a25a4
Compare
5ca3eb7 to
61bebb2
Compare
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
Signed-off-by: Om Mishra <32200996+mishraomp@users.noreply.github.com>
|
@DerekRoberts it is in a good shape now, I think we can run the crunchy action in parallel while images are getting build, it will speed up the pipeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the deployment configuration for the Crunchy PostgreSQL cluster and streamlines related workflows. Key changes include:
- Updating chart values for PostgreSQL and storage settings in charts/crunchy/values.yml.
- Enhancing secret retrieval logic in charts/app/templates/secret.yaml.
- Replacing custom removal commands with the bcgov/action-crunchy action in the pr-close workflow and updating deployment steps in .github/workflows/.deployer.yml.
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/crunchy/values.yml | Updated PostgreSQL version and adjusted storage size and postGISVersion formatting. |
| charts/app/templates/secret.yaml | Modified secret naming logic and added explicit lookup validations. |
| .github/workflows/pr-close.yml | Replaced manual DB user removal steps with the new bcgov/action-crunchy action. |
| .github/workflows/.deployer.yml | Updated deployment steps to use the new crunchy action and added a debugging step. |
Files not reviewed (7)
- .github/workflows/.deployer-db.yml: Language not supported
- backend/package.json: Language not supported
- charts/crunchy/Chart.yaml: Language not supported
- charts/crunchy/templates/PostgresCluster.yaml: Language not supported
- charts/crunchy/templates/_helpers.tpl: Language not supported
- charts/crunchy/templates/knp.yaml: Language not supported
- charts/crunchy/templates/secret.yaml: Language not supported
Comments suppressed due to low confidence (1)
charts/crunchy/values.yml:8
- The postGISVersion value was changed from a quoted string to an unquoted numerical value. Please confirm that this type change is intentional and compatible with downstream processing.
postGISVersion: 3.4
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: