Skip to content

Allow falsey values in const properties #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2021
Merged

Allow falsey values in const properties #398

merged 2 commits into from
Sep 12, 2021

Conversation

@johnbillion
Copy link
Contributor

@johnbillion johnbillion commented Jun 2, 2021

Fixes #393

@bcherny
Copy link
Owner

bcherny commented Sep 12, 2021

Thanks for the bugfix!

bcherny
bcherny approved these changes Sep 12, 2021
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bcherny bcherny merged commit 90c1b56 into bcherny:master Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcherny bcherny bcherny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect type for a const with an empty string value

2 participants

@johnbillion @bcherny