Fixes import errors in Python 3.6 #52 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephLin
changed the title
jhavl
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @petercorke,
Many thanks for developing this wonderful package!
As mentioned in https://github.com/petercorke/spatialmath-python/issues/52#issuecomment-1135414149, I found that the following import behavior does not work in Python 3.6 due to circular imports (but works in 3.7+, which is mentioned in python/cpython#74210):
https://github.com/petercorke/spatialmath-python/blob/da5aa910617869715da9e661da475ba83b28c59f/spatialmath/base/transforms3d.py#L24
Therefore, I manage to fix this issue by simply modifying the statement to let the project work fine in Python 3.6 as well.
Please let me know if you have any questions or comments for this pull request. Thank you!
Best,
Yu-Kai