Rename Windows 32-bit release artifacts to win32 #76
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # --- Windows (win32) --- | ||
| if [[ -d artifacts/windows-win32-artifacts ]]; then | ||
| for file in artifacts/windows-win32-artifacts/*.exe; do | ||
| base="$(basename "$file")" | ||
| target="$base" | ||
| if [[ "$base" != *-ia32.exe ]]; then | ||
| target="${base%.exe}-ia32.exe" | ||
| if [[ "$base" == *-ia32* ]]; then | ||
| target="${base//-ia32/-win32}" | ||
| elif [[ "$base" != *-win32.exe ]]; then | ||
| target="${base%.exe}-win32.exe" | ||
| fi | ||
| cp "$file" "release_upload/$target" | ||
| done | ||
| for file in artifacts/windows-ia32-artifacts/*.exe.blockmap; do | ||
| for file in artifacts/windows-win32-artifacts/*.exe.blockmap; do | ||
| base="$(basename "$file")" | ||
| target="$base" | ||
| if [[ "$base" != *-ia32.exe.blockmap ]]; then | ||
| target="${base/.exe/-ia32.exe}" | ||
| if [[ "$base" == *-ia32* ]]; then | ||
| target="${base//-ia32/-win32}" | ||
| elif [[ "$base" != *-win32.exe.blockmap ]]; then | ||
| target="${base/.exe/-win32.exe}" | ||
| fi | ||
| cp "$file" "release_upload/$target" | ||
| done | ||
| if [[ -f artifacts/windows-ia32-artifacts/latest.yml ]]; then | ||
| cp artifacts/windows-ia32-artifacts/latest.yml release_upload/latest-ia32.yml | ||
| if [[ -f artifacts/windows-win32-artifacts/latest.yml ]]; then | ||
| cp artifacts/windows-win32-artifacts/latest.yml release_upload/latest-win32.yml | ||
| fi |
There was a problem hiding this comment.
The release step now renames 32‑bit Windows installers and blockmaps from *-ia32* to *-win32*, but it still uploads the unmodified latest.yml generated by electron‑builder. That metadata file continues to reference the original *-ia32* filenames, so the auto‑updater will try to download *-ia32.exe assets that no longer exist once the files have been renamed to *-win32.exe. This will break updates for Windows 32‑bit builds. The metadata needs to be rewritten (or generated with win32 names) to match the renamed artifacts before copying.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f38a082bb8833297fd4da6904ca14f