BVAL-672 Add @PastOrPresent and @FutureOrPresent#121
Merged
gunnarmorling merged 2 commits intojakartaee:masterfrom Jun 21, 2017
Merged
BVAL-672 Add @PastOrPresent and @FutureOrPresent#121gunnarmorling merged 2 commits intojakartaee:masterfrom
gunnarmorling merged 2 commits intojakartaee:masterfrom
Conversation
Contributor
gsmet
commented
Jun 21, 2017
gsmet
commented
- https://hibernate.atlassian.net/browse/BVAL-672
gunnarmorling
approved these changes
Jun 21, 2017
| * the constraint is on a {@link Year}, present would mean the whole current year. | ||
| * | ||
| * @return {@code true} if the present date should be considered valid | ||
| */ |
Contributor
There was a problem hiding this comment.
Ha, we didn't even have the @since tag; it had to be wrong ;)
| /** | ||
| * The annotated element must be an instant, date or time in the present or in the future. | ||
| * <p> | ||
| * <i>Now</i> is defined by the {@link ClockProvider} attached to the {@link javax.validation.Validator} |
Contributor
There was a problem hiding this comment.
I'd prefer simple names (via imports) as opposed to FQNs in JavaDoc. Can be done as a follow-up, though.
Contributor
|
Merged; thanks, @gsmet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.