Elixir update #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: use Mix.Config is deprecated. Use the Config module instead config/config.exs:3
warning: Supervisor.Spec.supervise/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead lib/radius/supervisor.ex:17: Radius.Supervisor.init/1 warning: Supervisor.Spec.worker/2 is deprecated. Use the new child specifications outlined in the Supervisor module instead lib/radius/supervisor.ex:14: Radius.Supervisor.init/1
warning: System.stacktrace/0 is deprecated. Use __STACKTRACE__ instead Invalid call found at 2 locations: lib/radius/dict.ex:220: Radius.Dict.load/1 lib/radius/dict.ex:221: Radius.Dict.load/1
warning: :crypto.hmac/3 is undefined or private, use crypto:mac/4 instead lib/radius/packet.ex:233: Radius.Packet.encode/2
warning: ^^^ is deprecated. It is typically used as xor but it has the wrong precedence, use Bitwise.bxor/2 instead lib/radius/util.ex:52:11 warning: use Bitwise is deprecated. import Bitwise instead lib/radius/util.ex:4: Radius.Util
Owner
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to use this library but it isn't really up to date. Here are some changes that should make it work with elixir >= 1.12 and otp >= 22. I haven't been able to test elixir 1.12 (don't have it locally), but it does work on elixir 1.13 and otp 24 and elixir 1.14 and otp 25. I wouldn't mind setting up github ci if you're open for more PRs.
Each commit can be viewed separately for easier review (I hope). The tests pass :)