Skip to content

fix(retry-job): [backport] include job name#236

Merged
skeggse merged 1 commit into
2.xfrom
fix-bull-job-retry
Aug 6, 2020
Merged

fix(retry-job): [backport] include job name#236
skeggse merged 1 commit into
2.xfrom
fix-bull-job-retry

Conversation

@skeggse
Copy link
Copy Markdown
Member

@skeggse skeggse commented Aug 5, 2020

#223 broke retries and delayed job triggering.

Fixes #234.

This broke retries and delayed job triggering.
@skeggse skeggse added the bug label Aug 5, 2020
@skeggse skeggse added this to the 2.8.3 milestone Aug 5, 2020
@skeggse skeggse self-assigned this Aug 5, 2020
@skeggse skeggse requested a review from shils August 5, 2020 23:30
@skeggse
Copy link
Copy Markdown
Member Author

skeggse commented Aug 5, 2020

@dhritzkiv if convenient, could you see if this solves your problem?

@skeggse skeggse linked an issue Aug 5, 2020 that may be closed by this pull request
@skeggse
Copy link
Copy Markdown
Member Author

skeggse commented Aug 5, 2020

My testing indicates that this worked.

@skeggse skeggse merged commit 4ccaf7e into 2.x Aug 6, 2020
@skeggse skeggse deleted the fix-bull-job-retry branch August 6, 2020 02:41
beequeueci pushed a commit that referenced this pull request Aug 6, 2020
### [2.8.3](v2.8.2...v2.8.3) (2020-08-06)

### Bug Fixes

* **retry-job:** include job name ([#236](#236)) ([4ccaf7e](4ccaf7e))
@beequeueci
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhritzkiv
Copy link
Copy Markdown

Awesome!

I wasn't able to break my workflow to test yet, but I imagine this is the fix. Thank you!

skeggse pushed a commit that referenced this pull request Aug 6, 2020
* **retry-job:** include job name ([#236](#236))
  ([4ccaf7e](4ccaf7e))
beequeueci pushed a commit that referenced this pull request Aug 6, 2020
### [2.8.3](v2.8.2...v2.8.3) (2020-08-06)

### Bug Fixes

* **retry-job:** include job name ([#236](#236)) ([4ccaf7e](4ccaf7e))
beequeueci pushed a commit that referenced this pull request Aug 6, 2020
### [2.8.3](v2.8.2...v2.8.3) (2020-08-06)

### Bug Fixes

* **retry-job:** include job name ([#236](#236)) ([4ccaf7e](4ccaf7e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Named jobs are triggered with __default__ name

3 participants