Skip to content

Validate filename length #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Validate filename length #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e75003c
fix: validate filename length
beeb Feb 9, 2023
5d43bdf
test: add special char test case
beeb Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,14 @@ pub(crate) async fn parse_config() -> Result<Params> {
})
}

/// Only keep recommended chars for S3 object keys
/// Only keep recommended chars for S3 object keys and truncate to 1000 chars
fn sanitize_filename(filename: impl Into<String>) -> String {
let mut filename: String = filename.into();
// remove invalid characters
filename.retain(|c| c.is_ascii_alphanumeric() || VALID_FILENAME_CHARS.contains(c));
filename
// since we only have ascii and single-byte special chars, we should be able to keep 1024 chars to stay under
// 1024 bytes, but for good measure we'll limit to 1000
filename.chars().take(1000).collect()
}

#[cfg(test)]
Expand All @@ -147,7 +149,8 @@ mod tests {
assert_eq!(&sanitize_filename("foo bar"), "foobar");
assert_eq!(&sanitize_filename("foo/bar"), "foo/bar");
assert_eq!(&sanitize_filename("foo.tar.gz"), "foo.tar.gz");
assert_eq!(&sanitize_filename("٣৬¾①"), "");
assert_eq!(&sanitize_filename("٣৬¾①🦀"), "");
assert_eq!(&sanitize_filename("!-_.*'()/"), "!-_.*'()/");
assert_eq!(sanitize_filename("Bar1".repeat(256)), "Bar1".repeat(250));
}
}