Skip to content

Conversation

@Derlys
Copy link
Collaborator

@Derlys Derlys commented Mar 28, 2024

No description provided.

@Derlys Derlys requested a review from beeman March 31, 2024 18:48
})
export class AccountService {
private readonly connection = new Connection(clusterApiUrl('devnet'));
private readonly _key = 'BJyq3roxaYEsPTs2';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key is not used.

CommonModule,
AppHeroComponent,
RouterLink,
JsonPipe,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JsonPipe is no longer used.

template: `
@if(publicKey()){
<div>
<a [routerLink]="['account/:c']">{{ publicKey() }}</a>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the route and change the logic:

@if (!publicKey()) {
  // select wallet
}

@Component({
selector: 'dapp-account-balance',
standalone: true,
imports: [CommonModule, JsonPipe, BalanceSolComponent],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for JsonPipe

@@ -1,11 +1,15 @@
import { CommonModule } from '@angular/common';
import { Component } from '@angular/core';
import { Component, effect, inject } from '@angular/core';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

effect is not needed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants