Enable SSL termination for the container for local dev #48
Conversation
|
@bryanlatten Ready for review. SSL is now enabled at "docker run" time. Certs are mapped from local file system. Tested both ubuntu and alpine build & run for SSL. |
Dockerfile
Outdated
| apt-get install -yqq --no-install-recommends \ | ||
| nginx-light \ | ||
| && \ | ||
| apt-get install -yqq --no-install-recommends \ |
There was a problem hiding this comment.
this installation can be combined right below nginx-light, no need for an additional install line
Dockerfile-alpine
Outdated
| apk add \ | ||
| nginx \ | ||
| && \ | ||
| apk add \ |
There was a problem hiding this comment.
can also be combined with above
README.md
Outdated
| Provides base OS, patches and stable nginx for quick and easy spinup. | ||
|
|
||
| [S6](https://github.com/just-containers/s6-overlay) process supervisor is used for `only` for zombie reaping (as PID 1), boot coordination, and termination signal translation | ||
| [S6](https://github.com/just-containers/s6-overlay) process supervisor is used for `only` for zombie reaping (as PID 1), boot coordination, and termination signal translation |
There was a problem hiding this comment.
It looks like your editor clipped the whitespace, which is important in MD files
|
@bryanlatten Okay, I made updates per suggestions. |
| listen 8080; | ||
|
|
||
| #ssl on; | ||
| #ssl_protocols TLSv1 TLSv1.1 TLSv1.2; |
There was a problem hiding this comment.
please remove TLSv1 (and possibly 1.1) from the list
There was a problem hiding this comment.
|
@nalshamma a PR was just merged adding cent to the mix. Can you handle that one too? |
|
@bryanlatten merge completed |
|
Superseded by #74 NOTE: the warning for duplicate server_name is due to your |
3 participants
@bryanlatten Still WIP. I ended up doing two implementations, and prefer the one using CONTAINER_SSL and CONTAINER_PORT. I would remove the SERVER_ENABLE_SSL implementation.
The tests currently fail if you use --build-args CONTAINER_SSL=true with this problem, although I can run with https on the container:
$ nginx -t
nginx: [warn] conflicting server name "" on 0.0.0.0:8080, ignored
I have deferred working on alpine while still being reviewed.