fix: debug format string #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current format string's conversion specifier %c and x1 with '0' added to it do not properly handle cases where reg is x10 to x30. This takes the value passed to x1 as an integer and processes it with the conversion specifier %u.
below
reviewed
Nov 21, 2024
Chapter 11/debug.s
Outdated
| stp X14, X15, [SP, #-16]! | ||
| stp X16, X17, [SP, #-16]! | ||
| stp X18, LR, [SP, #-16]! | ||
| mov X1, #\reg // for the %c |
Owner
There was a problem hiding this comment.
If I understood what you said correctly, the comment here should be "for the %u", too, correct?
Contributor
Author
There was a problem hiding this comment.
You are right. It should be %u.
Owner
|
And thank you so much for your changes and your attention to detail! I did not have sufficient time to review them, but they all should be merged soon! |
neldredge
added a commit
to neldredge/HelloSilicon
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current format string's conversion specifier
%candx1with'0'added to it do not properly handle cases where theregisx10throughx30— register name is two-digit number. i.e. there is an incorrect assumption that onlyx0throughx9will be passed.This fix takes the
regpassed tox1as an integer and processes it with the conversion specifier%u; We align the field to left with-2.As a side effect, only
x0needs to be moved later when callingprintf, and it doesn't matter which one is moved first:x1,x2, orx3.