Conversation
Contributor
|
For DAAAASSS |
lib/normalize2.js
Outdated
|
|
||
| function add(entity, tech) { | ||
| const str = naming.stringify(entity) + tech; | ||
| let str = entity.block + '__' + entity.elem + '_' + entity.modName + '_' + entity.modVal; |
Member
Author
There was a problem hiding this comment.
bem-naming ignore cases where block null or undefined which important for us.
lib/normalize2.js
Outdated
| } else { | ||
| block = entity.block; | ||
| block = entity.block || null; | ||
| elem = entity.elem; |
Contributor
There was a problem hiding this comment.
Well, I guess this is the same for elem.
Could you add some cases without block and elem?
Contributor
|
LGTM |
Member
|
🎱 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#49
But with small change due to result order. Block and his mods should be first.