Skip to content
This repository was archived by the owner on Aug 22, 2019. It is now read-only.

Conversation

@zhanghongce
Copy link
Contributor

@zhanghongce zhanghongce commented Dec 16, 2018

  • Remove global variable meta which is unused
  • Store range info in ast_port_declaration
  • Copy as_bits field to avoid being changed

List of changes

  • src/verilog_ast.h: remove meta from line 1092
  • src/verilog_parser.y : use range_o to replace NULL for non-terminal: port_declaration_l
  • src/verilog_ast.c: use ast_strdup in function ast_new_number

Fixes:

  • Now it is fine for others to include the headers in multiple source files.
  • ast_number->as_bits are usable
  • Range can be obtained in ast_port_declaration (for new style module declaration)

@ben-marshall ben-marshall merged commit f7463ca into ben-marshall:master Dec 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants