Fix bug in split-ellipses mode #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body was disappeared after formatting. Modeled after commit ca5c270, which fixed the same issue for split mode.
Owner
|
Big thanks for the PR! I'll review it shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The body was disappeared after formatting.
Modeled after commit ca5c270, which fixed the same issue for split mode.
If and when these changes reach https://github.com/bendera/vscode-commit-message-formatter, I believe the changes should fix bendera/vscode-commit-message-formatter#3.
Note: To be fully transparent, I did not figure out how to build the extension or run its tests. What I did do is try my best to make equivalent changes to CommitMessageFormatter.js in my installed copy of the extension. I then used the modified extension to format the "raw" text of the added test case and manually verified that it resulted in the "expected" text.