Skip to content

Return promise in initSessionService #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Return promise in initSessionService #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/__tests__/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,9 @@ describe('API functions', () => {
const session = { token: '12341234' };
beforeAll((done) => {
store = createStore(sessionReducer, initialState);

// wait for refresh redux store from localStorage
const unsubscribe = store.subscribe(() => {
unsubscribe();
sessionService.initSessionService(store).then( () => {
done();
});
sessionService.initSessionService(store);
})
});

describe('refreshFromLocalStorage', () => {
Expand Down
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class sessionService {

static initSessionService(store, options) {
instance = new sessionService(store, options);
sessionService.refreshFromLocalStorage();
return sessionService.refreshFromLocalStorage();
}

static initServerSession(store, req, options) {
Expand Down Expand Up @@ -72,7 +72,7 @@ export class sessionService {
return sessionService.loadSession()
.then(() => {
instance.store.dispatch(getSessionSuccess());
sessionService.loadUser().then((user) => {
return sessionService.loadUser().then((user) => {
instance.store.dispatch(getUserSessionSuccess(user));
})
.catch(() => {
Expand Down