Use coloured fonts if supported

[SteveCEvans]

Use coloured fonts if possible.

Display RSSI dBm as critical if below threshold.

Display all RX related warnings as critical.

Tested on WS firmware 34.40.12.

https://youtu.be/HkRrbCb4Vl8

[github-actions]

Do you want to test this code? You can flash it directly from Betaflight Configurator:

• Simply put #13005 (this pull request number) in the Select commit field of the Configurator firmware flasher tab (you need to Enable expert mode, Show release candidates and Development).

WARNING: It may be unstable. Use only for testing!

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> PASS
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> PASS
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> FAIL
• assigned to an approver -> PASS
• approver count at least three -> PASS

[McGiverGim]

Tested on WS firmware 34.40.12.

I suppose this is not a public version, so this PR can't be tested until published.

How this works? It's able to colour a custom font uploaded or only valid for preinstalled font?

[SteveCEvans]

Correct, not publicly available. This is recorded in this PR for the record. See https://betaflight.com/docs/development/API/DisplayPort MSP_DP_WRITE_STRING for details of the font usage. I anticipate these being user customisable.

[freasy]

Code looks good apart from config calls. Please evaluate if they are costly, if yes, I recommend local const initialization of those values.

[freasy]

If this runs in the loop, I would load the config value in the init function, as config calls are expensive correct?

There are couple of config calls, I think we should initialize the all in a local variable in init.

[SteveCEvans]

These setting can be changed on the fly outside of initialisation. Config access is considered low cost as it's held in RAM. osdConfig()-> appears in https://github.com/betaflight/betaflight/blob/321fd468fd2f3be78681d45e3e578cd768c3f26c/src/main/osd/osd_elements.c 53 times for such comparisons, or, for example, determining which unit symbols to display.

[SteveCEvans]

It’s been reported that WTFOS is currently confused by this update. The simple workaround is to set ‎displayport_msp_fonts = 0,0,0,0 until they add support for four fonts.

[Themightybert95]

Thanks

[kenmccann]

It’s been reported that WTFOS is currently confused by this update. The simple workaround is to set ‎displayport_msp_fonts = 0,0,0,0 until they add support for four fonts.

You are my hero.