fix(api-key): calling client on server side (#4777)

Author: himself65

e2e/smoke/test/ssr.ts

@@ -0,0 +1,76 @@
+import { betterAuth } from "better-auth";
+import { describe, test } from "node:test";
+import { DatabaseSync } from "node:sqlite";
+import { apiKey } from "better-auth/plugins";
+import { createAuthClient } from "better-auth/client";
+import { apiKeyClient } from "better-auth/client/plugins";
+import { getMigrations } from "better-auth/db";
+import assert from "node:assert/strict";
+
+describe("server side client", () => {
+	test("can use api key on server side", async () => {
+		const database = new DatabaseSync(":memory:");
+		const auth = betterAuth({
+			baseURL: "http://localhost:3000",
+			database,
+			socialProviders: {
+				github: {
+					clientId: process.env.GITHUB_CLIENT_ID as string,
+					clientSecret: process.env.GITHUB_CLIENT_SECRET as string,
+				},
+			},
+			emailAndPassword: {
+				enabled: true,
+			},
+			plugins: [
+				apiKey({
+					rateLimit: {
+						enabled: false,
+					},
+				}),
+			],
+		});
+
+		const { runMigrations } = await getMigrations(auth.options);
+		await runMigrations();
+
+		const authClient: ReturnType<typeof createAuthClient> = createAuthClient({
+			baseURL: "http://localhost:3000",
+			plugins: [apiKeyClient()],
+			fetchOptions: {
+				customFetchImpl: async (url, init) => {
+					return auth.handler(new Request(url, init));
+				},
+			},
+		});
+
+		const { user } = await auth.api.signUpEmail({
+			body: {
+				name: "Alex",
+				email: "alex@test.com",
+				password: "hello123",
+			},
+		});
+
+		const { key, id, userId } = await auth.api.createApiKey({
+			body: {
+				name: "my-api-key",
+				userId: user.id,
+			},
+		});
+
+		const ret = database.prepare(`SELECT * FROM apiKey;`).all();
+		assert.equal(ret.length, 1);
+		const first = ret.at(-1)!;
+		assert.equal(first.id, id);
+		assert.equal(first.userId, userId);
+
+		await authClient.getSession({
+			fetchOptions: {
+				headers: {
+					"x-api-key": key,
+				},
+			},
+		});
+	});
+});

packages/better-auth/src/api/to-auth-endpoints.ts

@@ -1,9 +1,9 @@
 import {
 	APIError,
-	toResponse,
 	type EndpointContext,
 	type EndpointOptions,
 	type InputContext,
+	toResponse,
 } from "better-call";
 import type { AuthEndpoint, AuthMiddleware } from "./call";
 import type { AuthContext, HookEndpointContext } from "../types";
@@ -81,7 +81,16 @@ export function toAuthEndpoints<E extends Record<string, AuthEndpoint>>(
 				internalContext = defuReplaceArrays(rest, internalContext);
 			} else if (before) {
 				/* Return before hook response if it's anything other than a context return */
-				return before;
+				return context?.asResponse
+					? toResponse(before, {
+							headers: context?.headers,
+						})
+					: context?.returnHeaders
+						? {
+								headers: context?.headers,
+								response: before,
+							}
+						: before;
 			}
 
 			internalContext.asResponse = false;