-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Migrate from LegacyColor
to bevy_color::Color
#12163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 58 commits into
bevyengine:main
from
alice-i-cecile:color-externals
Feb 29, 2024
Merged
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
b684a2a
Initial port of bevy_gizmos
138e26c
Use impl Into<Color> args in gizmo builder methods
fa8ad85
Merge remote-tracking branch 'origin/main' into color-externals
21de265
Use new convenience method in aabb.rs
e00b6bd
Fix color constants in gizmo docs tests
c07ec86
Remove unused import
d0dedbd
Add Color::srgba_u8
9d1f0d5
Add `Alpha::set_alpha` method
3829efd
Port over fog
ba58dc9
Port over ClearColor
8bc6c4f
Add new deprecated Color convenience methods
8e8d237
Port wireframes
1df0713
Port sprites
1b46fd1
Port text
0cfe96f
Add Alpha::is_fully_transparent and is_fully_opaque
c6806fa
Port bevy_ui
2ae656c
Add Mul and Div for LinearRgba
0621f62
Port standard material
5d8212e
Port lights
fe75eac
Register color types
a6b8fb4
Fix some doc tests
00616e2
Port ColorMaterial and MaterialMesh2d
80cb407
Port UI outlines
b7598cd
Add RED/GREEN/BLUE color constants
edd6988
to_array -> to_f32_array
d88b2fa
Add LinearRgba::as_u32
58c2eab
Eliminate remaining uses of `LegacyColor`
c2f52b0
Remove LegacyColor
1fb2f55
Merge remote-tracking branch 'origin/main' into color-externals
a094530
Use to_f32_array for fog code
0dd2ba4
Use WHITE constant
alice-i-cecile 6b50ac6
set_alpha for Oklcha
948c1ee
Fix fog typo
6d2848e
Port over newly added code
ca5f22f
Merge branch 'color-externals' of https://github.com/alice-i-cecile/b…
fd6616f
Undo Color::NONE -> Color::TRANSPARENT
6a03503
Clippy
66833d4
Merge remote-tracking branch 'origin/main' into color-externals
07500da
Add deprecated rgb_linear methods to ease migration
86614a9
Fix doc tests failing in CI
5e52c49
Clean up redundant import
3d7f8d2
Tidy up examples
rparrett 76567a6
Merge pull request #164 from rparrett/color-externals-examples
alice-i-cecile 2072eee
More CI failures
4f3115d
Merge branch 'color-externals' of https://github.com/alice-i-cecile/b…
d2a8e12
Fixup bad rebase
rparrett c06d915
Fix clippy
rparrett 8181762
Use .into where possible
rparrett cf8c4c7
Use color mixing in example
alice-i-cecile 075600b
Improve rgb_from_array
alice-i-cecile 1503719
Merge pull request #165 from rparrett/color-externals-clippy
alice-i-cecile 13584c7
Fix more doc tests
502f9d6
Merge branch 'main' into color-externals
alice-i-cecile 246e65a
Typo in doc test
03fdefc
Use `LinearRgba` in more rendering doc tests
ced8cd4
Fix doc test
c7fd5e3
Remove Add and Sub from LinearRgba
d400acb
More doc tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shame to add new deprecated functions but definitely better for this transitional period than the alternative!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I realized that I could do this to ease migration, and promptly started laughing due to how silly it is to add new immediately deprecated functions.