-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Rename bevy_reflect
's documentation
feature to reflect_documentation
#21577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR renames a Cargo feature. Should this have a migration guide? Users who explicitly enabled If needed, I‘ll add a migration guide. |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I quite like this change but it needs a migration guide entry :)
7b1a9fd
to
62ac359
Compare
release-content/migration-guides/rename-reflect-documentation-feature.md
Outdated
Show resolved
Hide resolved
62ac359
to
fc13b30
Compare
fc13b30
to
b38cac6
Compare
Objective
Fixes #14309
Solution
Renamed the
bevy_reflect
feature fromdocumentation
toreflect_documentation
to follow the naming convention where features are prefixed with their module name.Changes
documentation
toreflect_documentation
in:bevy_reflect/Cargo.toml
bevy_reflect/derive/Cargo.toml
bevy_internal/Cargo.toml
#[cfg(feature = "documentation")]
to#[cfg(feature = "reflect_documentation")]
reflect_docs.rs
Testing