Skip to content

Make WinitMonitors public #21786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2025
Merged

Make WinitMonitors public #21786

merged 1 commit into from
Nov 9, 2025

Conversation

@SludgePhD
Copy link
Contributor

@SludgePhD SludgePhD commented Nov 8, 2025

Objective

  • Allow third-party code to integrate with winit MonitorHandles represented by bevy Monitor entities.

Solution

  • Reexport this resource type, just like WinitWindows.
  • It was already part of the public API through the system types.

HugoPeters1024
HugoPeters1024 approved these changes Nov 9, 2025
View reviewed changes
Copy link
Contributor

@HugoPeters1024 HugoPeters1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the creator of a third party rendering plugin for Bevy, I believe allowing superusers to hook into these kinds handles is very important! Thanks for the contribution 💪

I'd love to actually see an example that makes some kind of integrations directly on the winit layer, that way the bevy devs are reminded to keep those options in the public interface. But that's a separate issue.

@alice-i-cecile alice-i-cecile added this to the 0.17.3 milestone Nov 9, 2025
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 9, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 9, 2025
Merged via the queue into bevyengine:main with commit dc22ec3 Nov 9, 2025
43 checks passed
mockersf pushed a commit that referenced this pull request Nov 17, 2025
@SludgePhD @mockersf
Make WinitMonitors public (#21786)
48556b7 
# Objective

- Allow third-party code to integrate with winit `MonitorHandle`s
represented by bevy `Monitor` entities.

## Solution

- Reexport this resource type, just like `WinitWindows`.
- It was already part of the public API through the system types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@HugoPeters1024 HugoPeters1024 HugoPeters1024 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.17.3

Development

Successfully merging this pull request may close these issues.

3 participants

@SludgePhD @alice-i-cecile @HugoPeters1024