Add support for world space UI #21812

MushineLament · 2025-11-12T03:34:49Z

Preface

Added feature 'bevy_ui_container' to ensure normal functioning of other functions

Objective

~~Fixes #21278~~
Try #5476

Existing problems:

...

Expectations and difficulties:

~~Non root nodes take effect (May affect the entire Node)~~
~~UiContain supports Visibility (Restricted by the relationship of visibility)~~

Solution

1.Ui follows the world from a point (Transfrom) to move
2.Modify Ui Layout Size Source (UiContainerSize)
3.Place Node in UiContainer for rendering(Use UiContainerTarget to specify Container)

Testing

Did you test these changes? If so, how?
I changed the UiSurface Resource that Node relies on in the test to Component, and its result is consistent with the Camera Node.
Are there any parts that need more testing?

The Button function of Container Node may need to be tested
Is there a performance issue
Does screen scaling affect the proper functioning of containers
Zindex has not been tested

Showcase

…obalTransfrom;Correct the coordinate system of UiContain Children Node

github-actions · 2025-11-12T03:43:07Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

…the Contain Node; Add some tests

github-actions · 2025-11-15T11:14:23Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

github-actions · 2025-11-15T11:52:34Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

ickshonpe · 2025-11-18T00:27:29Z

The example needs to be run with the "bevy_ui_container" feature enabled:

cargo run --example ui_container --features bevy/bevy_ui_container

Otherwise it doesn't work correctly.

Cargo.toml

example required features bevy_ui_container Co-authored-by: ickshonpe <david.curthoys@googlemail.com>

fix word error Co-authored-by: ickshonpe <david.curthoys@googlemail.com>

ickshonpe

I think the feature gate should be removed, world UI is fairly fundamental and probably not something that should be feature gated.

And also just for this PR, it adds a lot of extra noise that makes the changes more difficult to review.

fix word error Co-authored-by: ickshonpe <david.curthoys@googlemail.com>

MushineLament · 2025-11-18T00:55:17Z

I think the feature gate would probably be better removed, world UI is fairly fundamental and probably not something that should be feature gated.

And also just for this PR, it adds a lot of extra nouse that makes the changes more difficult to review.

Yes, perhaps we need to open a new create or plugin?
I think I can try. I have come up with a solution

ickshonpe · 2025-11-18T01:54:31Z

crates/bevy_ui_render/src/box_shadow.rs

        });
+        #[cfg(feature = "bevy_ui_container")]
+        {
+            let Ok(view) = camera_views.get(default_camera_view.ui_container) else {


This doesn't look right, if you run:
cargo run --example testbed_ui --features bevy/bevy_ui_container
there are visual artifacts which seem to result from drawing some of the phase items twice?
There are similar problems with the other queue_* functions.

MushineLament · 2025-11-18T12:53:29Z

@ickshonpe
I have reduced the extra noise and will migrate to the new plugin. To be honest, I don't want to remove the feature gate.

SuitedRioter · 2025-11-18T16:14:22Z

crates/bevy_ui/src/container.rs

+        let Ok((scale, size)) = query_ui_scale.get(target.0) else {
+            return;
+        };
+


Why is it "return"? Shouldn't it be "continue"?

The rendering code for the UiContainer still has some issues. This is related to the UiCameraView, which necessitates the existence of both UiCamera and UiContainer. I plan to decouple them to reduce dependency and improve performance.

alice-i-cecile · 2025-11-18T16:44:50Z

I don't want this feature-gated either. I think it adds complexity, and makes it harder to reason about how layout works.

MushineLament · 2025-11-18T23:57:38Z

我也不希望这个功能被限制。我觉得这增加了复杂性，也让理解布局的运作变得更难。

Since the majority of the members agree, I plan to remove the feature gate.

github-actions · 2025-11-19T13:57:02Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

github-actions · 2025-11-19T14:04:31Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

SuitedRioter · 2025-11-20T02:42:49Z

Judging from your modifications to UiSurface and UiScale, it appears that your PR lacks a systematic approach to bevy_ui. Instead, it seems you made changes based on a targeted look at certain parts of the code, resulting in several adjustments that do not align with Bevy’s current architecture and design principles. Therefore, I suggest you first explain your design approach, discuss it with the team, and then proceed with the changes before submitting the PR.

MushineLament · 2025-11-20T07:49:21Z

Judging from your modifications to UiSurface and UiScale, it appears that your PR lacks a systematic approach to bevy_ui. Instead, it seems you made changes based on a targeted look at certain parts of the code, resulting in several adjustments that do not align with Bevy’s current architecture and design principles. Therefore, I suggest you first explain your design approach, discuss it with the team, and then proceed with the changes before submitting the PR.

Yes, there is indeed this issue. My design solution is based on an idea: since the UI is laid out relative to the camera—where the camera acts as a "container for the UI"—and this container always follows the camera, why not define a container in world space to hold the UI and make the UI follow this container? For this purpose, I designed UiContainerSize, which corresponds to the layout size of the camera.

After considering the above, I distinguish between UI laid out in world space and UI laid out relative to the camera as ContainerUI (perhaps it could be called WorldUI?) and CameraUI, because there are slight differences between them, such as in the coordinate system.

(Regarding the multiple "fix ci" issues—I admit it's just a personal habit of preferring to make improvements on relatively correct and standardized code.)

github-actions · 2025-11-20T08:53:47Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

github-actions · 2025-11-20T08:54:08Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21812

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

Mushine Lament added 11 commits November 10, 2025 18:10

add a feature 'bevy_ui_contain'

dfc0355

add base components

f4d79fa

Rendering in the World based on UiContainTarget

9513089

Correct the Contain Root Node coordinates,And follow the UiContain Gl…

f5a719a

…obalTransfrom;Correct the coordinate system of UiContain Children Node

Rendering coordinate system correction

7d5fef7

overflow finish,but not test

0477c4d

fmt

baa78c6

Support switching between camera node and contain node

338cffa

Fix image not displaying when switching

b9b49a5

fmt;Example of adding guide text

837f5f3

fix example

4389045

Mushine Lament added 4 commits November 12, 2025 12:40

fix ci

9b5274d

fix ci

9c6b4d1

add tests;but ui_rounding_test error

17d4d53

Add UiScale component to UiContain; Modify the layout size source of …

bd5cb60

…the Contain Node; Add some tests

fix ci

64a5418

Mushine Lament and others added 11 commits November 15, 2025 21:18

Fix vertical flipping error of images in UiContain

e0650f1

fix ci

cef8b12

fix ci

c20e7fa

fix ci

b93046b

Improve the example;add tests

929a857

Rename to UiContainer;fix ci

2de3757

Merge branch 'bevyengine:main' into ui_contain_finally

036f4fa

Rename to UiContainer;fix ci

a99230c

fix ci;performance optimization

54a358b

fix ci;performance optimization;improve example

34d92d1

fix ci

884e58a

ickshonpe reviewed Nov 18, 2025

View reviewed changes

Cargo.toml Show resolved Hide resolved

MushineLament and others added 2 commits November 18, 2025 08:46

Update Cargo.toml

7a69c82

example required features bevy_ui_container Co-authored-by: ickshonpe <david.curthoys@googlemail.com>

Update examples/ui/ui_container.rs

2274743

fix word error Co-authored-by: ickshonpe <david.curthoys@googlemail.com>

ickshonpe reviewed Nov 18, 2025

View reviewed changes

Update examples/ui/ui_container.rs

71ad434

fix word error Co-authored-by: ickshonpe <david.curthoys@googlemail.com>

ickshonpe reviewed Nov 18, 2025

View reviewed changes

Mushine Lament added 6 commits November 18, 2025 19:20

Migration to plugins

e26a347

fix use err

f9c7494

fix ci

14ed923

fix ci

81dcfa1

fix ci;Add filtering options for UiRootNodes

cbb8fec

fix ci

9879b42

Mushine Lament added 2 commits November 18, 2025 20:58

fix ci

8866622

fix ci

4fbfdd8

SuitedRioter reviewed Nov 18, 2025

View reviewed changes

Mushine Lament added 2 commits November 19, 2025 21:50

just remove �evy_ui_container feature gate

f458cf0

fix ci

24eaaba

Mushine Lament and others added 2 commits November 20, 2025 16:46

Stop Uisurface as a component;fix Propagate UiContainerTarget error

6f21f75

Merge branch 'main' into ui_contain_finally

176f37e

Uh oh!

Add support for world space UI #21812

Are you sure you want to change the base?

Add support for world space UI #21812

Conversation

MushineLament commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preface

Objective

Existing problems:

Expectations and difficulties:

Solution

Testing

Showcase

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

ickshonpe commented Nov 18, 2025

Uh oh!

Uh oh!

ickshonpe left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MushineLament commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ickshonpe Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

MushineLament commented Nov 18, 2025

Uh oh!

SuitedRioter Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

MushineLament Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile commented Nov 18, 2025

Uh oh!

MushineLament commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

SuitedRioter commented Nov 20, 2025

Uh oh!

MushineLament commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MushineLament commented Nov 12, 2025 •

edited

Loading

ickshonpe left a comment •

edited

Loading

MushineLament commented Nov 18, 2025 •

edited

Loading