Skip to content

Add tests for processor initialization and fix a bug with initialization. #21855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2025
Merged

Add tests for processor initialization and fix a bug with initialization. #21855

merged 3 commits into from
Nov 20, 2025
+289 −18

Conversation

@andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Nov 16, 2025

Objective

  • We have no tests on the initialization process with an existing processing state.
  • There was a bug (caught by these tests!) where we were deleting directories while we were iterating through them, resulting in us missing directories in some cases.

Solution

  • Add two tests to ensure processor init does what we expect with existing processed assets.
  • Store all the empty directories in a Vec while iterating and then delete them all after we're done iterating.

Testing

  • Yup!

@andriyDev andriyDev force-pushed the processor-init-tests branch from 725ce35 to a3fa4b3 Compare November 16, 2025 05:26
@andriyDev
Copy link
Contributor Author

andriyDev commented Nov 16, 2025

CI breakage is unrelated and probably broken on main.

@andriyDev andriyDev added A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 16, 2025
@andriyDev andriyDev added this to the 0.18 milestone Nov 16, 2025
@andriyDev
Copy link
Contributor Author

andriyDev commented Nov 16, 2025

CI should be fixed by #21818

@andriyDev andriyDev force-pushed the processor-init-tests branch from a3fa4b3 to f76d513 Compare November 16, 2025 07:50
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 16, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 20, 2025
Merged via the queue into bevyengine:main with commit 7ad5fb7 Nov 20, 2025
38 checks passed
@andriyDev andriyDev deleted the processor-init-tests branch November 20, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@greeble-dev greeble-dev greeble-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

4 participants

@andriyDev @kristoff3r @greeble-dev @alice-i-cecile