Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
get_path_refmethod for AssetServer #10685AssetServer::get_pathrequires cloning theAssetPathfor each handle, which can be inefficientSolution
AssetServer::get_path_ref()method that returns a reference to the asset path without cloningAssetPathRefstruct that holds a read lock guard and dereferences toAssetPath<'static>AssetInfos::get_path_ref()helper method to retrieve path references from asset indicesAssetPathRefimplementsDeref<Target = AssetPath<'static>>, allowing transparent access to the path while keeping the lock aliveTesting
cargo check --package bevy_assetAssetServermethods that use read locksAssetServer::load()get_path_ref()on asset IDs/handlesReviewers can test by: