Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The proposed "Resources as entities" PR makes Resource implement Component. This creates a situation where we need to do:
I'm of the mind that we should add the ability for TypeData to have "dependencies". Ex
reflect(Resource)impliesreflect(Component). For "subtrait" types, I think supporting this is logical / users would appreciate it.Solution
FromType<T>::insert_dependenciesfunction with a default impl (which makes this a non-breaking change). This does kind of overload theFromTypetrait (ex: a name likeGetTypeDatamight be better with this new context), but this is a pretty niche trait / piece of functionality, and I like the idea of not breaking people.TypeRegistration::register_type_data<T, V>function, which initializes the TypeDataTfor a given typeV, inserts that type data, and also inserts any dependent type data usinginsert_dependencies.Reflectmacro to useregister_type_datainstead ofinsert(FromType::<Self>::from_type())This makes it possible to do the following:
Which then allows dropping
reflect(Component):Testing
I added a unit test 😜