Skip to content

fix all clippy lints #24475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 2 commits into from
Jun 2, 2026
Merged

fix all clippy lints #24475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c7e71
fix all clippy lints
laundmo May 29, 2026
13cb374
Use _ syntax for f32
alice-i-cecile Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ ref_as_ptr = "warn"
# see: https://github.com/bevyengine/bevy/pull/15375#issuecomment-2366966219
too_long_first_doc_paragraph = "allow"

std_instead_of_core = "warn"
# currently falsely fires on std::io, even tho core::io is unstable
# https://github.com/rust-lang/rust-clippy/issues/13158#issuecomment-4373196346
Copy link
Copy Markdown
Contributor

@SpecificProtagonist SpecificProtagonist May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR has been merged, can you please make an issue to re-enable the lint when Bushrat's fix is merged?

Copy link
Copy Markdown
Member Author

@laundmo laundmo Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no clue why github didn't show it when it was created, but Alice beat me to it while merging this: #24510

std_instead_of_core = "allow"
std_instead_of_alloc = "warn"
alloc_instead_of_core = "warn"

Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_animation/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1756,7 +1756,7 @@ mod tests {
AnimationTargetId::from_names(name_path.iter()),
"{:?} {:?}",
str_path,
&name_path
name_path
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_asset/src/reflect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ impl ReflectDeserializerProcessor for HandleDeserializeProcessor<'_> {
else {
return Err(D::Error::custom(format!(
"Could not find asset type by name \"{}\" for UntypedHandle",
&typed_handle_reference.asset_type
typed_handle_reference.asset_type
)));
};
let type_id = asset_type.type_id();
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_ecs/src/query/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ mod tests {
sorted.sort();
assert!(expected.contains(&sorted),
"the results of iter_combinations should contain this combination {:?}. Expected: {:?}, got: {:?}",
&sorted, &expected, &values);
sorted, expected, values);
});
}

Expand Down
4 changes: 2 additions & 2 deletions crates/bevy_feathers/src/controls/text_input.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ impl FeathersTextInput {
Node {
flex_grow: {
if props.visible_width.is_some() {
0.
0_f32
} else {
1.
1_f32
}
} ,
}
Expand Down
6 changes: 3 additions & 3 deletions crates/bevy_math/src/bounding/bounded2d/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ mod bounding_circle_tests {
#[test]
fn grow() {
let a = BoundingCircle::new(Vec2::ONE, 5.);
let padded = a.grow(1.25);
let padded = a.grow(1.25_f32);
assert!(ops::abs(padded.radius() - 6.25) < f32::EPSILON);
assert!(padded.contains(&a));
assert!(!a.contains(&padded));
Expand All @@ -719,7 +719,7 @@ mod bounding_circle_tests {
#[test]
fn shrink() {
let a = BoundingCircle::new(Vec2::ONE, 5.);
let shrunk = a.shrink(0.5);
let shrunk = a.shrink(0.5_f32);
assert!(ops::abs(shrunk.radius() - 4.5) < f32::EPSILON);
assert!(a.contains(&shrunk));
assert!(!shrunk.contains(&a));
Expand All @@ -728,7 +728,7 @@ mod bounding_circle_tests {
#[test]
fn scale_around_center() {
let a = BoundingCircle::new(Vec2::ONE, 5.);
let scaled = a.scale_around_center(2.);
let scaled = a.scale_around_center(2_f32);
assert!(ops::abs(scaled.radius() - 10.) < f32::EPSILON);
assert!(!a.contains(&scaled));
assert!(scaled.contains(&a));
Expand Down
6 changes: 3 additions & 3 deletions crates/bevy_math/src/bounding/bounded3d/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ mod bounding_sphere_tests {
#[test]
fn grow() {
let a = BoundingSphere::new(Vec3::ONE, 5.);
let padded = a.grow(1.25);
let padded = a.grow(1.25_f32);
assert!(ops::abs(padded.radius() - 6.25) < f32::EPSILON);
assert!(padded.contains(&a));
assert!(!a.contains(&padded));
Expand All @@ -771,7 +771,7 @@ mod bounding_sphere_tests {
#[test]
fn shrink() {
let a = BoundingSphere::new(Vec3::ONE, 5.);
let shrunk = a.shrink(0.5);
let shrunk = a.shrink(0.5_f32);
assert!(ops::abs(shrunk.radius() - 4.5) < f32::EPSILON);
assert!(a.contains(&shrunk));
assert!(!shrunk.contains(&a));
Expand All @@ -780,7 +780,7 @@ mod bounding_sphere_tests {
#[test]
fn scale_around_center() {
let a = BoundingSphere::new(Vec3::ONE, 5.);
let scaled = a.scale_around_center(2.);
let scaled = a.scale_around_center(2_f32);
assert!(ops::abs(scaled.radius() - 10.) < f32::EPSILON);
assert!(!a.contains(&scaled));
assert!(scaled.contains(&a));
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_reflect/src/func/dynamic_function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ impl_type_path!((in bevy_reflect) DynamicFunction<'env>);
/// [overloaded]: DynamicFunction::with_overload
impl<'env> Debug for DynamicFunction<'env> {
fn fmt(&self, f: &mut Formatter<'_>) -> core::fmt::Result {
write!(f, "DynamicFunction({:?})", &self.internal)
write!(f, "DynamicFunction({:?})", self.internal)
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_reflect/src/func/dynamic_function_mut.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ impl<'env> DynamicFunctionMut<'env> {
/// [overloaded]: DynamicFunctionMut::with_overload
impl<'env> Debug for DynamicFunctionMut<'env> {
fn fmt(&self, f: &mut Formatter<'_>) -> core::fmt::Result {
write!(f, "DynamicFunctionMut({:?})", &self.internal)
write!(f, "DynamicFunctionMut({:?})", self.internal)
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_render/src/render_resource/sparse_buffer_vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ fn update_sparse_buffers(
command_encoder.begin_compute_pass(&ComputePassDescriptor {
label: Some(&*format!(
"sparse buffer update ({})",
&sparse_buffer_update_job.label
sparse_buffer_update_job.label
)),
timestamp_writes: None,
});
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_settings/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ fn save_preferences(world: &mut World, use_async: bool, force: bool) {

// Update timestamps
let mut registry = world.get_resource_mut::<PreferencesFileRegistry>().unwrap();
for (_, manifest) in registry.files.iter_mut() {
for manifest in registry.files.values_mut() {
manifest.last_save = this_run;
}
}
Expand Down
6 changes: 3 additions & 3 deletions crates/bevy_ui/src/layout/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,18 +642,18 @@ mod tests {
);
assert_eq!(
taffy_style.grid_template_rows,
vec![sh::length(10.0), sh::percent(0.5), sh::fr(1.0)]
vec![sh::length(10_f32), sh::percent(0.5_f32), sh::fr(1_f32)]
);
assert_eq!(
taffy_style.grid_template_columns,
vec![sh::repeat(5, vec![sh::length(10.0)])]
vec![sh::repeat(5, vec![sh::length(10_f32)])]
);
assert_eq!(
taffy_style.grid_auto_rows,
vec![
sh::fit_content(taffy::style::LengthPercentage::length(10.0)),
sh::fit_content(taffy::style::LengthPercentage::percent(0.25)),
sh::minmax(sh::length(0.0), sh::fr(2.0)),
sh::minmax(sh::length(0_f32), sh::fr(2_f32)),
]
);
assert_eq!(
Expand Down
2 changes: 1 addition & 1 deletion tools/build-templated-pages/src/features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fn parse_features(panic_on_missing: bool) -> Vec<Feature> {
.flat_map(|v| v.as_str().map(|s| format!("`{}`", s)))
.collect::<Vec<_>>()
.join(", ");
description.push_str(&format!(" **Feature set:** {}.", &features));
description.push_str(&format!(" **Feature set:** {}.", features));
}

Some(Feature {
Expand Down
14 changes: 7 additions & 7 deletions tools/example-showcase/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,16 +613,16 @@ required_features = {:?}
WebApi::Webgl2 => "",
},
to_show.category,
&to_show.technical_name.replace('_', "-"),
&to_show.technical_name.replace('_', "-"),
to_show.technical_name.replace('_', "-"),
to_show.technical_name.replace('_', "-"),
match api {
WebApi::Webgpu => "-webgpu",
WebApi::Webgl2 => "",
},
&beautified_category,
&to_show.technical_name.replace('_', "-"),
&to_show.category,
&to_show.technical_name,
beautified_category,
to_show.technical_name.replace('_', "-"),
to_show.category,
to_show.technical_name,
match api {
WebApi::Webgpu => "-webgpu",
WebApi::Webgl2 => "",
Expand All @@ -633,7 +633,7 @@ required_features = {:?}
.collect::<PathBuf>()
.display(),
to_show.shader_paths,
&to_show.path,
to_show.path,
match api {
WebApi::Webgpu => "WebGPU",
WebApi::Webgl2 => "WebGL2",
Expand Down
Loading