Skip to content

[Merged by Bors] - Fix hardcoded texture bind group index in bevy_ui #3905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix hardcoded texture bind group index in bevy_ui #3905

wants to merge 1 commit into from

Conversation

@rparrett
Copy link
Contributor

@rparrett rparrett commented Feb 9, 2022

Objective

While looking at #3896, I noticed the same error in the equivalent location in bevy_ui.

Solution

Fix it in the same way.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 9, 2022
@IceSentry IceSentry added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Feb 9, 2022
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 10, 2022
@mockersf
Copy link
Member

mockersf commented Feb 12, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 12, 2022
@rparrett
Fix hardcoded texture bind group index in bevy_ui (#3905)
6475268 
# Objective

While looking at #3896, I noticed the same error in the equivalent location in `bevy_ui`.

## Solution

Fix it in the same way.
@bors
Copy link
Contributor

bors bot commented Feb 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix hardcoded texture bind group index in bevy_ui [Merged by Bors] - Fix hardcoded texture bind group index in bevy_ui Feb 12, 2022
@bors bors bot closed this Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rparrett @mockersf @IceSentry