Fix bevy_ui compilation failure without bevy_text #8985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
added
A-UI
nicopap
force-pushed
the
fix-bevy-ui-no-text
branch
from
2f8f2f5 to
baa1517
Compare
ickshonpe
reviewed
Jun 29, 2023
| height: size.y, | ||
| } | ||
| }; | ||
| self.measure_func = Some(MeasureFunc::Boxed(Box::new(measure_func))); |
Contributor
There was a problem hiding this comment.
This looks much cleaner. We should be using type aliases for taffy types in the layout module too maybe.
ickshonpe
approved these changes
Jun 29, 2023
Contributor
ickshonpe
left a comment
ickshonpe
left a comment
There was a problem hiding this comment.
Fixes the compilation issues and the refactorings are nice.
ickshonpe
reviewed
Jun 29, 2023
wilk10
approved these changes
Jun 30, 2023
Contributor
wilk10
left a comment
wilk10
left a comment
There was a problem hiding this comment.
I don't mind the sneaky refactor, and the fix for the compilation failure is pretty elegant, imo. Well done!
nicopap
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_uidoesn't compile without thebevy_textfeature #8984Solution
I admit: I did sneak it an unrelated mini-refactor. of the
measurment.rsmodule. it seemed to me that directly importingtaffytypes helped reduce a lot of boilerplate, so I did it.