-
Notifications
You must be signed in to change notification settings - Fork 1
Remove segment marker assignment in WordPress #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklhtv
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
javascript
Pull requests that update Javascript code
php
Pull requests that update Php code
wip
Work in Progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes all logic related to the
beyondwordsMarkerattribute from both the PHP backend and JavaScript frontend. The attribute is no longer added to blocks, its controls and UI have been removed, and all related helper functions and code paths have been deleted. Additionally, new logic is introduced to ensure BeyondWords attributes and controls are only added to supported content blocks, preventing issues with internal or UI blocks.Removal of beyondwordsMarker attribute and related logic:
beyondwordsMarkerattribute to Gutenberg blocks and removed the associated filter and rendering logic fromBlockAttributes.php. The attribute is now deprecated and only kept for backward compatibility in registration. [1] [2] [3]addMarkerAttribute,addMarkerAttributeWithHTMLTagProcessor, andaddMarkerAttributeWithDOMDocumentfromPostContentUtils.php.getSegmentsmethod, which previously handled segmenting content by blocks and markers.Frontend JavaScript cleanup and improvements:
getBlockMarkerAttributehelper and related filters. [1] [2] [3] [4] [5] [6] [7]isBeyondwordsSupportedBlockutility to ensure BeyondWords attributes and controls are only added to appropriate content blocks, skipping internal, UI, and container blocks.Documentation and comments:
These changes streamline the codebase, prevent potential UI issues, and clarify the plugin's behavior regarding block attributes.