Skip to content

Conversation

@bc-terra
Copy link
Collaborator

@bc-terra bc-terra commented Oct 24, 2025

…arameters for clarity

DEVDOCS-6566

What changed?

  • Adjusted placement of X-Store-Hash for clarity

Release notes draft

  • We've moved X-Store-Hash into authentication info rather than parameters to clarify its usage.

Anything else?

ping { @bigcommerce/dev-docs-team }

@bc-terra bc-terra added the ready for review This PR is complete and awaiting a review. label Oct 24, 2025
Copy link
Contributor

@bc-Vince bc-Vince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the PR look good, but it looks like the S2S Authentication endpoints also need this update. Also, the "get Server to Server Token" endpoint in that reference article does not require authentication headers, and it validates the store hash from the request body.

@bc-terra
Copy link
Collaborator Author

The changes in the PR look good, but it looks like the S2S Authentication endpoints also need this update. Also, the "get Server to Server Token" endpoint in that reference article does not require authentication headers, and it validates the store hash from the request body.

I have a separate PR for the authentication endpoints, since that one requires a bit of nuance to make sure it's addressed properly

@bc-Vince
Copy link
Contributor

The changes in the PR look good, but it looks like the S2S Authentication endpoints also need this update. Also, the "get Server to Server Token" endpoint in that reference article does not require authentication headers, and it validates the store hash from the request body.

I have a separate PR for the authentication endpoints, since that one requires a bit of nuance to make sure it's addressed properly

Since that's the case, I'll approve this one.

@bc-terra bc-terra merged commit 7174854 into main Oct 31, 2025
3 checks passed
@bc-terra bc-terra deleted the DEVDOCS-6566 branch October 31, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This PR is complete and awaiting a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants