Conversation
bc-max
reviewed
May 12, 2023
| <!-- test | ||
| {{{stylesheet '/assets/custom/css/test.css'}}} --> | ||
|
|
||
| more text here No newline at end of file |
Contributor
There was a problem hiding this comment.
Do we need all the stuff on lines 4 - 7?
Contributor
Author
There was a problem hiding this comment.
yeah, I'm basically targeting the multiline comments to be not included in the stylesheet ocurrences.
bc-max
approved these changes
May 12, 2023
Contributor
|
🎉 This PR is included in version 7.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jairo-bc
added a commit
to jairo-bc/stencil-cli
that referenced
this pull request
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Skip commented out code stylesheet usages during scss compilation validation step. Included also case with multiple ocurences of scss files on the page. Bumped cheerio
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team