feat: STRF-10840 Provide optional --branch to release command#1111
Merged
jairo-bc merged 1 commit intobigcommerce:masterfrom Jun 15, 2023
Merged
feat: STRF-10840 Provide optional --branch to release command#1111jairo-bc merged 1 commit intobigcommerce:masterfrom
jairo-bc merged 1 commit intobigcommerce:masterfrom
Conversation
bc-max
approved these changes
Jun 14, 2023
lib/release/release.js
Outdated
| throw new Error('Not on master branch, please checkout master branch to proceed'); | ||
| if (gitData.current !== options.branch) { | ||
| throw new Error( | ||
| `Not on ${options.branch} branch, please checkout master branch to proceed`, |
Contributor
There was a problem hiding this comment.
Suggested change
| `Not on ${options.branch} branch, please checkout master branch to proceed`, | |
| `Not on ${options.branch} branch, please checkout ${options.branch} branch to proceed`, |
I assume it is possible situation when gitData is on branch test1 and our input is test2. In this case error message will be confusing.
jmwiese
approved these changes
Jun 14, 2023
Contributor
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jairo-bc
added a commit
to jairo-bc/stencil-cli
that referenced
this pull request
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Added optional
--branch, -boptions to stencil release to support custom main branch nameTickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team