MERC-5890 Change naming WIDGET_BUILDER_STORE_HASH #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-jcha
commented
Dec 10, 2019
src/services/auth/authConfig.ts
Outdated
Contributor
Author
There was a problem hiding this comment.
Hmm wondering if I should also change this as storeHash
Contributor
There was a problem hiding this comment.
Yeah probably good idea for consistency
pedelman
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should refer to store id in the README as WIDGET_BUILDER_STORE_HASH instead of WIDGET_BUILDER_STORE_ID. We use store hash externally, and we refer to it that way in our developer docs: https://developer.bigcommerce.com/api-docs/getting-started/making-requests