Skip to content

Conversation

@KenelmQLH
Copy link
Collaborator

@KenelmQLH KenelmQLH commented Nov 13, 2021

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

(Brief description on what this PR is about)

What does this implement/fix? Explain your changes.

Merge dev branches into master

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [OTHER] Other (please describe):

Changes

  1. add BERT and pretrained model (luna_bert)
  2. speed up the process in sif
  3. handling OOV in word2vec
  4. add English tutorials
  5. add api docs and prettify tutorials
  6. fix the np.error in gensim_vec.W2V.infer_vector
  7. fix the parameters lost in tokenizationn

Does this close any currently open issues?

N/A

Any relevant logs, error output, etc?

N/A

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

karin0018 and others added 30 commits August 6, 2021 21:43
BAOOOOOM and others added 26 commits September 26, 2021 15:00
[BUGFIX] Fix the parameters lost in tokenization
[DOC]Add api docs and prettify tutorials
[FEATURE] modify is_sif,to_sif,sif4sci
[FEATURE] add pretrained model BERT
[DOC]add English version tutorial
 [DOC] Documentation content changes
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #106 (9071cca) into master (1a7fe0c) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #106      +/-   ##
===========================================
+ Coverage   99.85%   100.00%   +0.14%     
===========================================
  Files          46        48       +2     
  Lines        1364      1489     +125     
===========================================
+ Hits         1362      1489     +127     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
EduNLP/Formula/Formula.py 100.00% <ø> (ø)
EduNLP/ModelZoo/rnn/rnn.py 100.00% <ø> (ø)
EduNLP/ModelZoo/utils/masker.py 100.00% <ø> (ø)
EduNLP/ModelZoo/utils/padder.py 100.00% <ø> (ø)
EduNLP/Pretrain/gensim_vec.py 100.00% <ø> (ø)
EduNLP/SIF/segment/segment.py 100.00% <ø> (ø)
EduNLP/SIF/tokenization/formula/ast_token.py 100.00% <ø> (ø)
EduNLP/SIF/tokenization/formula/formula.py 100.00% <ø> (ø)
EduNLP/SIF/tokenization/formula/linear_token.py 100.00% <ø> (ø)
EduNLP/SIF/tokenization/text/tokenization.py 100.00% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7fe0c...9071cca. Read the comment docs.

* [FEATURE] Fix oov in word2vec

* Update CHANGE.txt
@tswsxk tswsxk merged commit d3cd6e2 into master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants