Skip to content

Conversation

@nnnyt
Copy link
Collaborator

@nnnyt nnnyt commented Nov 10, 2022

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

(Brief description on what this PR is about)

What does this implement/fix? Explain your changes.

  • Refactor tokenizer Basic Tokenizer and Pretrained Tokenizer
  • Refactor model structures following huggingface styles for Elmo, BERT, DisenQNet and QuesNet
  • Add PreprocessingPipeline and Pipeline
  • Add downstream task: knowledge prediction and property prediction
  • Fix a bug in RNN which causes ELMo not converging
  • Move all the test models to modelhub
  • Update test data files

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [OTHER] Other (please describe):

Changes

  • Refactor tokenizer Basic Tokenizer and Pretrained Tokenizer
  • Refactor model structures following huggingface styles for Elmo, BERT, DisenQNet and QuesNet
  • Add PreprocessingPipeline and Pipeline
  • Add downstream task: knowledge prediction and property prediction
  • Fix a bug in RNN which causes ELMo not converging
  • Move all the test models to modelhub
  • Update test data files

Does this close any currently open issues?

#127
#128
#129

Any relevant logs, error output, etc?

N/A

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

nnnyt and others added 30 commits June 17, 2022 17:39
@nnnyt nnnyt requested a review from tswsxk November 10, 2022 13:28
@tswsxk tswsxk merged commit 30a366a into master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants