Skip to content

Conversation

@KenelmQLH
Copy link
Collaborator

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

  1. add PureTextToeknizer and TextTokenizer for get_tokenizer
  2. add W2V for get_pretained_i2v

What does this implement/fix? Explain your changes.

N/A

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [OTHER] Other (please describe):

Changes

N/A

Does this close any currently open issues?

N/A

Any relevant logs, error output, etc?

N/A

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@KenelmQLH KenelmQLH changed the title [Fearture] Merge branch 'i2v' into master [FEATURE] Merge branch 'i2v' into master Aug 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #43 (61ef101) into master (51bbf2e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          46       46           
  Lines        1338     1363   +25     
=======================================
+ Hits         1336     1361   +25     
  Misses          2        2           
Impacted Files Coverage Δ
EduNLP/I2V/__init__.py 100.00% <100.00%> (ø)
EduNLP/I2V/i2v.py 100.00% <100.00%> (ø)
EduNLP/SIF/tokenization/tokenization.py 99.12% <100.00%> (+0.01%) ⬆️
EduNLP/Tokenizer/tokenizer.py 100.00% <100.00%> (ø)
EduNLP/Vector/t2v.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51bbf2e...61ef101. Read the comment docs.

@tswsxk tswsxk changed the title [FEATURE] Merge branch 'i2v' into master [FEATURE] Upgrade tokenizer and add new pretrained model: W2V Aug 20, 2021
@tswsxk tswsxk merged commit 85621a3 into master Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants