Skip to content

Conversation

@BAOOOOOM
Copy link
Collaborator

@BAOOOOOM BAOOOOOM commented Sep 10, 2021

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

(Brief description on what this PR is about)

What does this implement/fix? Explain your changes.

Update some documemts.
Fix some api documents.
Add a simple flow chart.

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [OTHER] Other (please describe):

Changes

  1. Update AUTHORS.md
  2. Update EduNLP/Formula/Formula.py
  3. Update EduNLP/I2V/i2v.py
  4. Update EduNLP/ModelZoo/rnn/rnn.py
  5. Update EduNLP/ModelZoo/utils/masker.py
  6. Update EduNLP/ModelZoo/utils/padder.py
  7. Update EduNLP/SIF/segment/segment.py
  8. Update EduNLP/Tokenizer/tokenizer.py
  9. Update EduNLP/Vector/gensim_vec.py
  10. Update EduNLP/Vector/t2v.py
  11. Update docs/source/_static/流程图.jpg
  12. Update docs/source/api/i2v.rst
  13. Update docs/source/api/sif.rst
  14. Update docs/source/tutorial/zh/index.rst
  15. Update docs/source/tutorial/zh/parse.rst
  16. Update docs/source/tutorial/zh/tokenize.rst
  17. Update examples/vectorization/i2v.ipynb
  18. Update tests/test_sif/test_tokenization.py
  19. Update tests/test_vec/test_vec.py

Does this close any currently open issues?

#71

Any relevant logs, error output, etc?

N/A

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #89 (1ff0c80) into docs (3c3ff14) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             docs       #89      +/-   ##
===========================================
+ Coverage   99.85%   100.00%   +0.14%     
===========================================
  Files          46        46              
  Lines        1364      1365       +1     
===========================================
+ Hits         1362      1365       +3     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
EduNLP/Formula/Formula.py 100.00% <ø> (ø)
EduNLP/ModelZoo/rnn/rnn.py 100.00% <ø> (ø)
EduNLP/ModelZoo/utils/masker.py 100.00% <ø> (ø)
EduNLP/ModelZoo/utils/padder.py 100.00% <ø> (ø)
EduNLP/Pretrain/gensim_vec.py 100.00% <ø> (ø)
EduNLP/SIF/segment/segment.py 100.00% <ø> (ø)
EduNLP/SIF/sif.py 100.00% <ø> (ø)
EduNLP/SIF/tokenization/formula/linear_token.py 100.00% <ø> (ø)
EduNLP/SIF/tokenization/tokenization.py 100.00% <ø> (+0.87%) ⬆️
EduNLP/Tokenizer/tokenizer.py 100.00% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3ff14...1ff0c80. Read the comment docs.

Copy link
Collaborator Author

@BAOOOOOM BAOOOOOM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@BAOOOOOM BAOOOOOM merged commit c2b4d87 into bigdata-ustc:docs Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants