Feature request: customizable test attributes

[robgjansen]

Thank you for your crate! :)

Would you consider supporting customizable test attributes? For example, I believe that currently tests are hard-coded to look like:

#[test]
fn my_test() {
    ...
}

But I would like to specify custom test attributes. Here is an example:

#[test]
#[ignore]
#[cfg(target_os = "linux")]
fn my_test() {
    ...
}

I think your code gets us pretty close, we just need a way to parse the attributes and paste them here instead of the hard-coded #[cfg(test)], right?

test-each-file/src/lib.rs

Lines 258 to 266 in 622d703

	if let Some(module) = parsed.module {
	tokens = quote! {
	#[cfg(test)]
	mod #module {
	use super::*;
	#tokens
	}
	}
	}

[JonathanBrouwer]

Hi! Thanks for the feedback.

I'm definitely open to supporting this.
The #[cfg(...)] attribute should also work fine if you place it on the test_each_file macro, but the #[ignore] would not.

To add this feature, the attributes would actually have to end up here (you found the generated module instead):

test-each-file/src/lib.rs

Line 230 in 622d703

#[test]

I'm mostly worried about the syntax of how to provide the custom attributes in a nice way in the macro. I thought about it for a bit but I can't come up with anything that I'm happy with. Feel free to propose a syntax, I'm tired from RustWeek so I could very well be missing something obvious.

Other than the syntax concern, feel free to implement this yourself (I'm happy to answer questions) or I'm happy to do it when I have some free time

[robgjansen]

Thanks for your response! I've been poking at this a bit. I think I got something working that is fairly elegant (i.e., in line with how extensions are parsed). I'll submit a PR shortly.