Add support for Python 3.11 #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an incompatibility with Python 3.11, where the dataclass implementation has changed to check for the immutability of default values by checking if they are hashable. This wasn't true for UnsetValue, so it couldn't be used as a default value anymore. For the Default classes, __hash__ isn't really necessary, but these objects still should be considered immutable.
binaryDiv
added
bug
ninanomenon
approved these changes
May 17, 2023
|
|
||
| def __eq__(self, other): | ||
| return other is self | ||
| # Don't define __eq__ because the default implementation is fine (identity check), and because we would then have to |
There was a problem hiding this comment.
Then why you don't remove the line?
Contributor
Author
There was a problem hiding this comment.
I'm not sure if I got your question ^^' You mean why I put the comment there instead of just removing the code?
Contributor
Author
There was a problem hiding this comment.
Mainly as a reminder for future me who might possibly see this class and say "hmm, why didn't we define __eq__ here, maybe I should add that, that sounds like a good idea" 😅
(On the other hand, the unit test would fail again then, so... shrug)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds official support for Python 3.11 to the library.
Python 3.11 was added as a target for the test environments (both tox for local testing and GitHub actions).
There was one incompatibility that needed to be fixed: In Python 3.11 the
@dataclassimplementation was changed to check for the immutability of default values by checking if they are hashable (i.e. if their classes have an implementation for__hash__). This wasn't true forUnsetValue, so it couldn't be used as a default value anymore.