EmailValidator: Add parameter to convert to lowercase #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryDiv
added
the
enhancement
binaryDiv
force-pushed
the
email-validator-auto-lowercase
branch
from
8e61ff9 to
9df1451
Compare
binaryDiv
changed the base branch from
dataclass-post-validate-without-varkwargs
to
main
binaryDiv
force-pushed
the
email-validator-auto-lowercase
branch
2 times, most recently
from
8bbe102 to
7809d68
Compare
|
I'm not quite sure what these changes are for and I have a few questions about validataclass basically, but that's outside the scope of the PR. So LGTM. |
Contributor
Author
Concrete example: When setting the email address of a user, it's useful to normalize it to be all-lowercase in the database so that logging in with the email address works case-insensitively. (The database could also do that of course, but I think it's best to directly store the normalized versions.) But the validator should still accept email addresses with uppercase letters because users might input it that way. |
binaryDiv
force-pushed
the
email-validator-auto-lowercase
branch
from
59152ae to
038c911
Compare
binaryDiv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the optional boolean parameter
to_lowercaseto theEmailValidator.If set, the output email address is automatically converted to lowercase. (Default: False)