[Bug]: Guard not being passed to permissions during sync

[craigrileyuk]

What happened?

As of v1.5, If you have a role with a guard other than 'web', the permissions created through that role are still given the guard of 'web'.

This issue isn't present in v1.4.

class AuditorRole extends DefinedRole
{
    /** @var array|string[]  */
    protected array $guards = [
        'admin'
    ];

    /**
     * List of enumerated permissions for the `admin` guard
     *
     * @return array
     */
    public function admin(): array
    {
        return [
            ...AuditAbility::cases()
        ];
    }
}

will create all permissions in the database with 'guard_name' of 'web' still. Then it errors during the 'SyncDefinedRoles' job because the permission with the guard_name of 'admin' doesn't exist.

How to reproduce the bug

Create a role without a web guard, and set it permissions.

Run the rbac:reset command.

Package Version

1.5.0

PHP Version

8.4.12

Laravel Version

12.31.1

Which operating systems does with happen with?

Linux

Notes

No response

[cyrillkalita]

@craigrileyuk take a look at custom guard tests in #25 - it does not fail on testing. Am i missing something?

[craigrileyuk]

@cyrillkalita Your tests must be missing something.

https://github.com/craigrileyuk/rbac-bug-repro

There's a reproduction using a fresh Laravel install. All I did was to switch to a new auth guard called 'admin'.

When running php artisan rbac:reset, you get:

php artisan rbac:reset
  BinaryCats\LaravelRbac\Jobs\FlushPermissionCache .................................................................................... 10.59ms DONE
  BinaryCats\LaravelRbac\Jobs\ResetPermissions ........................................................................................ 28.97ms DONE
  BinaryCats\LaravelRbac\Jobs\SyncDefinedRoles ......................................................................................... 7.88ms FAIL

   Spatie\Permission\Exceptions\PermissionDoesNotExist 

  There is no permission named `view test` for guard `admin`.

And, like I said, the exact same application works fine with version 1.4 of your package.

[cyrillkalita]

@craigrileyuk indeed

There was a change in internal action SyncDefinedRole, which handles, well syncing of roles to guards and permissions.

[cyrillkalita]

Resolved with #25
Please bump to version ^1.6