This repository was archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
🔨 Fix API call Schema types and body structure #278
Merged
utkarsha-deriv
merged 6 commits into
binary-com:master
from
utkarsha-deriv:utkarsha/API-call-schema-header-fix
Jan 9, 2024
Merged
🔨 Fix API call Schema types and body structure #278
utkarsha-deriv
merged 6 commits into
binary-com:master
from
utkarsha-deriv:utkarsha/API-call-schema-header-fix
Jan 9, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies, button array item types
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 7444710712
💛 - Coveralls |
amina-deriv
reviewed
Jan 5, 2024
...res/Apiexplorer/Schema/RecursiveContent/SchemaBodyHeader/__tests__/SchemaBodyHeader.test.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Jan 5, 2024
...res/Apiexplorer/Schema/RecursiveContent/SchemaBodyHeader/__tests__/SchemaBodyHeader.test.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Jan 5, 2024
...res/Apiexplorer/Schema/RecursiveContent/SchemaBodyHeader/__tests__/SchemaBodyHeader.test.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Jan 5, 2024
src/features/Apiexplorer/Schema/RecursiveContent/SchemaObjectContent/index.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Jan 5, 2024
...lorer/Schema/RecursiveContent/SchemaOneOfBodyHeader/__tests__/SchemaOneOfBodyHeader.test.tsx
Outdated
Show resolved
Hide resolved
amina-deriv
reviewed
Jan 8, 2024
src/features/Apiexplorer/Schema/RecursiveContent/SchemaBodyHeader/index.tsx
Outdated
Show resolved
Hide resolved
matin-deriv
approved these changes
Jan 8, 2024
amina-deriv
approved these changes
Jan 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will help to do following:
Fix
Schema Header
information for api calls using oneOf in JSON structureThis is done by creating new components
SchemaOneOfObjectContent
andSchemaOneOfBodyHeader
to handleoneOf
use case separatelySchemaOneOfBodyHeader
will display header based on the values coming fromoneOf
Fixes the display type of Array Items inside request/response body
Fixes Schema display of
crypto_config
and other api calls passingpattern
inside JSONTest cases for above changes and components
Added crypto_config, crypto_estimations api calls to dropdown