Skip to content

Conversation

@rupato-deriv
Copy link
Contributor

Added eslint-disable-next-line simple-import-sort/imports to exempt the import order from ESLint's automatic sorting. This change was necessary because our project requires a specific, predefined import order, which was causing test failures on Circle CI when ESLint reordered the imports automatically.

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 15, 2023 9:42am

@boring-cyborg boring-cyborg bot added the Bot label Sep 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10109](https://github.com/binary-com/deriv-app/pull/10109)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-eslint-order-sort.binary.sx?qa_server=red.binaryws.com&app_id=38778
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-eslint-order-sort.binary.sx
- **App ID**: `38778`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-fix-eslint-order-sort.binary.sx/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
26.1% 26.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants