Skip to content

[P2P]-refactor: order util refactor #10115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 15, 2023
Merged

[P2P]-refactor: order util refactor #10115

merged 10 commits into from
Dec 15, 2023

Conversation

@nada-deriv
Copy link
Contributor

@nada-deriv nada-deriv commented Sep 15, 2023

Changes:

order.js util typescript migration, and unit test

Screenshots:

Please provide some screenshots of the change.
Screenshot 2023-09-15 at 6 41 21 PM

@boring-cyborg boring-cyborg bot added the P2P label Sep 15, 2023
@vercel
Copy link

vercel bot commented Sep 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2023 9:40am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10115](https://github.com/binary-com/deriv-app/pull/10115)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1561order-util-refactor.binary.sx?qa_server=red.derivws.com&app_id=38778
    - **Original**: https://deriv-app-git-fork-nada-deriv-nada-p2ps-1561order-util-refactor.binary.sx
- **App ID**: `38778`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-nada-deriv-nada-p2ps-1561order-util-refactor.binary.sx/

ameerul-deriv
ameerul-deriv reviewed Sep 18, 2023
View reviewed changes
packages/p2p/src/utils/orders.ts Outdated
Comment on lines 354 to 353

get purchase_time() {
return getFormattedDateString(new Date(convertToMillis(this.order_details.created_time)), true);
}
Copy link
Contributor

@ameerul-deriv ameerul-deriv Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no i deleted purchase order_purchase_time in this pr 😆 #10069

farrah-deriv
farrah-deriv reviewed Sep 18, 2023
View reviewed changes
packages/p2p/src/utils/orders.ts
Comment on lines 537 to 544
/**
* Function that returns the user details of the order
*
* @returns {object} user details
*/
get my_user_details() {
return this.is_my_ad ? this.order_details.advertiser_details : this.order_details.client_details;
}
Copy link
Contributor

@farrah-deriv farrah-deriv Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we are using this. Can you please check and remove if not being used.

@coveralls
Copy link

coveralls commented Sep 19, 2023 •
edited
Loading

Coverage Status

coverage: 27.585% (+17.2%) from 10.385%
when pulling 3babe23 on nada-deriv:nada/P2PS-1561/order-util-refactor
into 5f0713a on binary-com:master.

ameerul-deriv
ameerul-deriv reviewed Sep 20, 2023
View reviewed changes
packages/p2p/src/components/order-details/order-details.jsx
label={labels.right_send_or_receive}
value={`${amount_display} ${account_currency}`}
/>
<OrderInfoBlock label={localize('Time')} value={purchase_time} />
Copy link
Contributor

@ameerul-deriv ameerul-deriv Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we keep purchase_time instead of order_purchase_time? cause its gonna cause conflicts with the other card 🙏

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 12 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
18.9% 18.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

farrah-deriv
farrah-deriv previously approved these changes Sep 21, 2023
View reviewed changes
@nada-deriv nada-deriv changed the title refactor: order util refactor [P2P]-refactor: order util refactor Nov 10, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.5% 10.5% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@farrah-deriv farrah-deriv merged commit 1d430b6 into deriv-com:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farrah-deriv farrah-deriv farrah-deriv left review comments

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

+2 more reviewers

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

P2P

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nada-deriv @coveralls @farrah-deriv @niloofar-deriv @ameerul-deriv