Maryia/DTRA-424/build: update deriv-charts to 1.4.0 #10225
Conversation
maryia-deriv
requested review from
ali-hosseini-deriv,
balakrishna-deriv,
matin-deriv,
prince-deriv,
sandeep-deriv and
yashim-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-maryia-deriv-maryia-dtra-424update-ch-423c1f.binary.sx/ |
| "@deriv/bot-skeleton": "^1.0.0", | ||
| "@deriv/components": "^1.0.0", | ||
| "@deriv/deriv-charts": "1.3.5", | ||
| "@deriv/deriv-charts": "1.4.0", |
There was a problem hiding this comment.
| "@deriv/deriv-charts": "1.4.0", | |
| "@deriv/deriv-charts": "^1.4.0", |
There was a problem hiding this comment.
If you add this symbol, we won't have to have a release and update every version manually, unless the new version contains breaking changes.
There was a problem hiding this comment.
@akmal-deriv we don't want to automatically install the latest version when devs bootstrap the app, we want an exact version instead. :)
| "@deriv/components": "^1.0.0", | ||
| "@deriv/deriv-api": "^1.0.11", | ||
| "@deriv/deriv-charts": "1.3.5", | ||
| "@deriv/deriv-charts": "1.4.0", |
There was a problem hiding this comment.
| "@deriv/deriv-charts": "1.4.0", | |
| "@deriv/deriv-charts": "^1.4.0", |
There was a problem hiding this comment.
@akmal-deriv we don't want to automatically install the latest version when devs bootstrap the app, we want an exact version instead. :)
| "@deriv/components": "^1.0.0", | ||
| "@deriv/deriv-api": "^1.0.11", | ||
| "@deriv/deriv-charts": "1.3.5", | ||
| "@deriv/deriv-charts": "1.4.0", |
There was a problem hiding this comment.
| "@deriv/deriv-charts": "1.4.0", | |
| "@deriv/deriv-charts": "^1.4.0", |
There was a problem hiding this comment.
@akmal-deriv we don't want to automatically install the latest version when devs bootstrap the app, we want an exact version instead. :)
…RA-424/update-charts-version-to-1.4.0
…RA-424/update-charts-version-to-1.4.0
…DTRA-424/update-charts-version-to-1.4.0
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | c399337 | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…RA-424/update-charts-version-to-1.4.0
maryia-deriv
requested review from
farrah-deriv and
nijil-deriv
as code owners
…RA-424/update-charts-version-to-1.4.0
…DTRA-424/update-charts-version-to-1.4.0
…RA-424/update-charts-version-to-1.4.0
|
Kudos, SonarCloud Quality Gate passed!
|
* build: update charts to 1.4.0 * chore: remove extra files
* build: update charts to 1.4.0 * chore: remove extra files
7 participants
Changes:
Screenshots:
Please provide some screenshots of the change.